[CI] Upgrade XamlStyler and remove .NET6 dependency #37574
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ready for review but CI keeps failing 😄 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
crutkas
added
the
Needs-Review
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidegiacometti
force-pushed
the
users/davidegiacometti/xamlstyler
branch
from
02aefa3 to
cddfada
Compare
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.pipelines/v2/templates/job-build-project.yml:142
- Removing the explicit .NET6 version check might cause builds to pick up an unintended SDK version. Consider explicitly specifying the target SDK version to ensure consistency in the build environment.
- - template: steps-ensure-dotnet-version.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
XamlStylerand removed .NET6 CI dependencydotnet-consolidatesince it was using an old version that also required .NET6Wondering if the Verify Nuget package versions for PowerToys.sln CI step and
dotnet-consolidateare obsolete since we the solution is using central package management: https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#enabling-central-package-managementPR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed